Skip to content

Conversation

@lizziel
Copy link
Contributor

@lizziel lizziel commented Feb 19, 2025

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Describe the update

This PR disables pole-averaging in the map_a2a horizontal regridding scheme when using CESM. This avoids introducing differences in 2D emissions when using different numbers of cores. This PR also updates several print statements to limit to root thread in order to reduce log redundancy when using MPI.

Note that after this PR there is still an issue in CESM with core-dependency. However, it will be limited to 3D emissions only.

Expected changes

This will be a zero difference update for GC-Classic and GCHP.

Reference(s)

none

Related Github Issue

None

@lizziel lizziel force-pushed the bugfix/remove_cesm_core_dependency branch 2 times, most recently from fad9146 to 8d3da7d Compare February 19, 2025 20:28
@lizziel lizziel changed the title Remove core dependency issue in CESM Remove core dependency of 2D emissions in CESM Feb 25, 2025
@lizziel lizziel changed the title Remove core dependency of 2D emissions in CESM Turn off map_a2a pole-averaging when using CESM Feb 25, 2025
@lizziel lizziel force-pushed the bugfix/remove_cesm_core_dependency branch from f2ded2b to 24868eb Compare February 25, 2025 20:04
@lizziel lizziel marked this pull request as ready for review February 25, 2025 20:06
@lizziel lizziel requested a review from yantosca February 25, 2025 20:06
@lizziel lizziel added topic: ESMF or MPI Related to issues in the ESMF and/or MPI environments category: Interface to External Model Related to HEMCO updates needed to interface with other models (GEOS, WRF, CESM, etc) labels Feb 25, 2025
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lizziel. These updates are OK to merge.

lizziel added 4 commits March 4, 2025 11:03
… MPI

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
The pole-averaging causes differences when changing number of cores in
MPI runs.
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel lizziel force-pushed the bugfix/remove_cesm_core_dependency branch from 24868eb to fe6c4b0 Compare March 4, 2025 16:04
@lizziel lizziel merged commit d7563e7 into dev/no-diff-to-benchmark Mar 4, 2025
15 checks passed
@lizziel lizziel deleted the bugfix/remove_cesm_core_dependency branch March 25, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: Interface to External Model Related to HEMCO updates needed to interface with other models (GEOS, WRF, CESM, etc) topic: ESMF or MPI Related to issues in the ESMF and/or MPI environments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants