Skip to content

[GEOT-7848] Move image mosaic tests to geopackage, fix tests failures after H2 removal #5454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aaime merged 1 commit into from
Dec 15, 2025
Merged

[GEOT-7848] Move image mosaic tests to geopackage, fix tests failures after H2 removal #5454

aaime merged 1 commit into from
Dec 15, 2025
+93 −94

Conversation

@MikhailLukyaniuk
Copy link
Contributor

@MikhailLukyaniuk MikhailLukyaniuk commented Dec 4, 2025 •
edited
Loading

GEOT-7848 Powered by Pull Request Badge

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • There is an issue in GeoTools Jira (except for changes not visible to end users).
  • Commit message(s) must be in the form [GEOT-XYZW] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • The commit targets a single objective (if multiple focuses cannot be avoided, each one is in its own commit, and has a separate ticket describing it).

@MikhailLukyaniuk MikhailLukyaniuk changed the title [GEOT-7848] Fix test failures after H2 removal [GEOT-7848] Fix tests failures after H2 removal Dec 4, 2025
@aaime aaime changed the title [GEOT-7848] Fix tests failures after H2 removal [GEOT-7848] Move image mosaic tests to geopackage, fix tests failures after H2 removal Dec 4, 2025
@MikhailLukyaniuk MikhailLukyaniuk force-pushed the GEOT-7848-move-image-mosaic-over-to-geopackage branch from f90d1dc to 372e152 Compare December 4, 2025 16:49
@aaime
Copy link
Member

aaime commented Dec 4, 2025

@MikhailLukyaniuk I see this test failing in github osx builder:

2025-12-04T17:33:43.6807230Z [ERROR] org.geotools.gce.imagemosaic.ImageMosaicReaderTest.testConcurrentHarvestAndRemoveGeoPackage -- Time elapsed: 3.958 s <<< FAILURE!
2025-12-04T17:33:43.6812430Z java.lang.AssertionError: Terminating test due to previous failures
2025-12-04T17:33:43.6813470Z 	at org.junit.Assert.fail(Assert.java:89)
2025-12-04T17:33:43.6815340Z 	at org.junit.Assert.assertTrue(Assert.java:42)
2025-12-04T17:33:43.6816490Z 	at org.junit.Assert.assertFalse(Assert.java:65)
2025-12-04T17:33:43.6881680Z 	at org.geotools.gce.imagemosaic.ImageMosaicReaderTest.checkConcurrentHarvestAndRemove(ImageMosaicReaderTest.java:5121)
2025-12-04T17:33:43.6936900Z 	at org.geotools.gce.imagemosaic.ImageMosaicReaderTest.testConcurrentHarvestAndRemoveGeoPackage(ImageMosaicReaderTest.java:5017)
2025-12-04T17:33:43.7064010Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2025-12-04T17:33:43.7071580Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
2025-12-04T17:33:43.7277520Z 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2025-12-04T17:33:43.7295800Z 	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
2025-12-04T17:33:43.7305490Z 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
2025-12-04T17:33:43.7306090Z 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
2025-12-04T17:33:43.7310370Z 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
2025-12-04T17:33:43.7311060Z 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
2025-12-04T17:33:43.7312420Z 	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
2025-12-04T17:33:43.7314950Z 	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)

It might not be immediate to reproduce locally, maybe try to increase the level of concurrency of the test?
GeoPackage is definitely not the best storage for this kind of test, as it was meant for a single user (H2 had a server mode instead).

@MikhailLukyaniuk MikhailLukyaniuk force-pushed the GEOT-7848-move-image-mosaic-over-to-geopackage branch 4 times, most recently from 398c98d to 6a1a61e Compare December 10, 2025 00:12
@MikhailLukyaniuk MikhailLukyaniuk force-pushed the GEOT-7848-move-image-mosaic-over-to-geopackage branch from 6a1a61e to ad3b43a Compare December 15, 2025 12:45
@MikhailLukyaniuk MikhailLukyaniuk force-pushed the GEOT-7848-move-image-mosaic-over-to-geopackage branch from ad3b43a to ef431a4 Compare December 15, 2025 14:46
@aaime
Copy link
Member

aaime commented Dec 15, 2025

Looks good, thanks!

@aaime aaime merged commit 4e8e47c into geotools:main Dec 15, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MikhailLukyaniuk @aaime