This repository was archived by the owner on Apr 16, 2024. It is now read-only.
Feature/#582 unit visibility toggle 2 #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced new Unit Property visible Added visible to all unit form components and unit model classes next step: make units invisible for students
kesselb
reviewed
Apr 21, 2018
| populate: { | ||
| path: 'units', | ||
| virtuals: true, | ||
| match: {$or: [{visible: undefined},{visible: true},{visible: !isTeacherOrAdmin}]}, |
|
Sorry, package.json and package-lock.json have been commited and pushed accidentally. Please do not merge. |
…gle-2' into feature/#582-unit-visibility-toggle-2
|
There are many Problems, we should discuss these Tomorrow. |
PatrickSkowronek
suggested changes
Apr 27, 2018
…e to undefined sometimes local user was undefined in readUser() function, one more check added
|
I still get this Error |
|
Ok. I am not able to reproduce this error. Could you show me the error in a personal session. |
…gle-2' into feature/#582-unit-visibility-toggle-2
PatrickSkowronek
approved these changes
May 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Simple Visiblility Toggle for Units (without Datepicker/visibleFromDate)
Closes #582
Improvements
Known Issues:
Remember to prefix your PR-Title with
⚠ WIP:if you still work on it.If you have reached a final state, remove the prefix.