Skip to content
This repository was archived by the owner on Apr 16, 2024. It is now read-only.

Add fileUnitType for FileUnit #907

Merged
merged 7 commits into from
Oct 26, 2018
Merged

Add fileUnitType for FileUnit #907

merged 7 commits into from
Oct 26, 2018

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented Oct 23, 2018 •
edited
Loading

Description:

For some units the field fileUnitType is missing. Save the record
again does the trick.

Improvements

  • No warning when migration data

Known Issues:

NONE

@kesselb
Add fileUnitType for FileUnit
4532420 
For some units the field fileUnitType is missing. Save the record
again does the trick.
@kesselb kesselb added the bug This Issue describes a unwanted behavior label Oct 23, 2018
@kesselb
Copy link
Contributor Author

kesselb commented Oct 23, 2018

Add 20181019-fileUnit.ts to #879 after merge

@coveralls
Copy link

coveralls commented Oct 23, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 223

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.3%) to 73.552%
Files with Coverage Reduction New Missed Lines %
api/src/controllers/DownloadController.ts 5 74.37%
api/src/models/units/CodeKataUnit.ts 20 58.78%
Totals Coverage Status
Change from base Build 218: -1.3%
Covered Lines: 1721
Relevant Lines: 2234
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 23, 2018

Pull Request Test Coverage Report for Build 166

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.503%
Totals Coverage Status
Change from base Build 154: 0.0%
Covered Lines: 1721
Relevant Lines: 2236
💛 - Coveralls

@kesselb kesselb added the api All Backend related Issues label Oct 25, 2018
@kesselb kesselb merged commit 49c8d41 into develop Oct 26, 2018
@kesselb kesselb deleted the bugfix/field-fileunittype-missing branch October 26, 2018 08:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@grosspersky grosspersky Awaiting requested review from grosspersky

@PatrickSkowronek PatrickSkowronek Awaiting requested review from PatrickSkowronek

@dboschm dboschm Awaiting requested review from dboschm

1 more reviewer

@Gargamil Gargamil Gargamil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api All Backend related Issues bug This Issue describes a unwanted behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kesselb @coveralls @Gargamil