Skip to content
This repository was archived by the owner on Apr 16, 2024. It is now read-only.

Remove @types/winston dependency #945

Merged
merged 4 commits into from
Oct 31, 2018
Merged

Remove @types/winston dependency #945

merged 4 commits into from
Oct 31, 2018

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented Oct 31, 2018

Description:

We removed winston. I assume the typescript binding is not longer required.

@kesselb kesselb requested review from Gargamil and dboschm October 31, 2018 13:38
@coveralls
Copy link

coveralls commented Oct 31, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 377

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.1%
Totals Coverage Status
Change from base Build 375: 0.0%
Covered Lines: 1719
Relevant Lines: 2243
💛 - Coveralls

@kesselb kesselb requested a review from torss October 31, 2018 21:40
dboschm
dboschm approved these changes Oct 31, 2018
View reviewed changes
Copy link
Collaborator

@dboschm dboschm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dboschm dboschm merged commit fa08c54 into develop Oct 31, 2018
@dboschm dboschm deleted the bugfix/drop-types-winston branch October 31, 2018 23:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gargamil Gargamil Awaiting requested review from Gargamil

@torss torss Awaiting requested review from torss

1 more reviewer

@dboschm dboschm dboschm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kesselb @coveralls @dboschm