arch-arm: Decouple insts from generated decoder #2623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@giactra let me know what you think on this. I don't love this solution, but I believe it's the best way to break this circular dependence. Please review at least semi-carefully. Gemini did (almost) all the work. (Note: More changes will be coming for circular dependences between arch/arm and arch/dev/arm once I get things to compile...) |
To compile the insts/ files separately from the generated files there was a circular dependence between the generated decoder.hh and sve_macromem.hh that had to be broken. decoder.hh defines the classes SveGatherLoadCpySrcVecMicroop and SveGatherLoadCpySrcVecMicroop which were used with `new` in the header file. Also, decoder.hh depends on all insts/*.hh files. To break this dependence, we need to move the constructor implementations into a cc file. However, the classes are template classes so we also need to specify all of the uses of the templates. I believe these are fixed, so they are manually added to sve_macromem.cc. Signed-off-by: Jason Lowe-Power <jlowepower@google.com>
ae26c06 to
639b9d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To compile the insts/ files separately from the generated files there was a circular dependence between the generated decoder.hh and sve_macromem.hh that had to be broken. decoder.hh defines the classes SveGatherLoadCpySrcVecMicroop and SveGatherLoadCpySrcVecMicroop which were used with
newin the header file. Also, decoder.hh depends on all insts/*.hh files.To break this dependence, we need to move the constructor implementations into a cc file. However, the classes are template classes so we also need to specify all of the uses of the templates. I believe these are fixed, so they are manually added to sve_macromem.cc.