fix(config): throw error if value contain not valid json string

seth2810 · seth2810 · commit 60cc4f0f8866 · 2016-11-06T23:08:51.000+03:00
diff --git a/lib/config/util.js b/lib/config/util.js
@@ -49,15 +49,11 @@ function parseBoolean(value) {
 }
 
 function parsePrimitive(str) {
-    let value;
-
     try {
-        value = JSON.parse(str);
+        return JSON.parse(str);
     } catch (error) {
-        // do nothing
+        throw new GeminiError('a value must be a primitive type');
     }
-
-    return value;
 }
 
 function positiveIntegerOption(defaultValue) {
diff --git a/test/unit/config-options/config-options.test.js b/test/unit/config-options/config-options.test.js
@@ -236,11 +236,11 @@ describe('config', function() {
             });
         });
 
-        it('should not throws if value from environment is not valid', () => {
+        it('should throw if value from environment is not valid', () => {
             ['{a:1}', '{', ']', '\'string\'', '\n'].forEach((value) => {
-                assert.doesNotThrow(() => {
+                assert.throw(() => {
                     assertParsesEnv({property: name, value});
-                });
+                }, GeminiError);
             });
         });
 
@@ -251,11 +251,11 @@ describe('config', function() {
             });
         });
 
-        it('should not throws if value from cli is not valid', () => {
+        it('should throw if value from cli is not valid', () => {
             ['{a:1}', '{', ']', '\'string\'', '\n'].forEach((value) => {
-                assert.doesNotThrow(() => {
+                assert.throw(() => {
                     assertParsesCli({property: name, value});
-                });
+                }, GeminiError);
             });
         });
     }
@@ -475,7 +475,7 @@ describe('config', function() {
             });
         });
 
-        describe.only('plugins', () => {
+        describe('plugins', () => {
             testObjectOption('system.plugins.plugin');
         });
     });

Original file line number	Diff line number	Diff line change
`@@ -49,15 +49,11 @@ function parseBoolean(value) {`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`function parsePrimitive(str) {`
`52`		`- let value;`
`53`		`-`
`54`	`52`	`try {`
`55`		`- value = JSON.parse(str);`
	`53`	`+ return JSON.parse(str);`
`56`	`54`	`} catch (error) {`
`57`		`- // do nothing`
	`55`	`+ throw new GeminiError('a value must be a primitive type');`
`58`	`56`	`}`
`59`		`-`
`60`		`- return value;`
`61`	`57`	`}`
`62`	`58`
`63`	`59`	`function positiveIntegerOption(defaultValue) {`