Allow some capture elements to be missing#282
Allow some capture elements to be missing#282fenduru wants to merge 1 commit intogemini-testing:masterfrom
Conversation
Previously Gemini would through an error if any of the selectors passed to setCaptureElement were non-existent. This changes the behavior to only throw an error if all of the selectors are non-existent.
130df9b to
ac91107
Compare
|
@fenduru unfortunately I can't merge this because it's breaking documented behavior. Looking at #231 it looks like you just need to define custom suite for case when your popup is not opened yet. |
|
The way the docs are currently written, I think this change is actually fixing a bug in the implementation.
I would prefer that you reconsider this PR, but if you don't want to then I think the docs should be updated. If you don't want to reconsider, what would you think about adding an additional function called |
|
@SwinX thoughts? |
|
Seems like you just need to prepare code under test in a way it would be stable and will produce same layout all the time. |
|
There is no way for me to have the code being tested always produce the same layout because of the way Angular.Js works. I agree that the "all capture elements are optional and missing" is a weird case. I'll just work around this by having separate suites and incur the extra page loads for these tests. |
|
@fenduru, yes, having separate suites for each case is right way for testing. |
Previously Gemini would through an error if any of the selectors
passed to setCaptureElement were non-existent. This changes the behavior
to only throw an error if all of the selectors are non-existent.
fixes #231