Skip to content

error in Fortran MPI image count check #17

Closed

Description

@scivision

Currently numerical/grid/grid.f90:grid_check() does some basic sanity checks. However a lot of bad cases can get through, causing a non-obvious error like putting NaNs in plasma variables or MUMPS failing to solve. Normally, the Python front-end will only give "good" number of MPI images. However if a user manually specifies the number of MPI images, grid_check() often doesn't catch the problem, and so we get NaN check errors or MUMPS memory errors.

Examples triggering error

there are many more cases that will fail, this is just one example of each.

NaN in v1

python scripts/run_test.py 2dew_fang mpiexec.exe build/gemini.bin.exe build/test2dew_fang -np 3

(now fixed)

mumps error

python scripts/run_test.py 2dew_fang mpiexec.exe build/gemini.bin.exe build/test2dew_fang -np 7

Activity

  1. changed the title [-]Should add Fortran MPI image count check[/-] [+]enhance Fortran MPI image count check[/+] on Apr 1, 2020
  2. mattzett commented on Jun 11, 2020

    @mattzett
    Member

    We continue to have issues with the mpi image count checking and init. As of the latest commit specifying a manual grid is the only way to be sure that it will run correctly... This appears to be relatively recent as my students are using versions several weeks old and have not complained about this bug at all.

  3. changed the title [-]enhance Fortran MPI image count check[/-] [+]error in Fortran MPI image count check[/+] on Jun 11, 2020
  4. scivision commented on Aug 19, 2020

    @scivision
    MemberAuthor

    This has been fixed by checks so that these configurations promptly error like:

    ERROR:grid_size_root: Number of MPI images along x3     7 not a factor of lx3all:     40
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingenhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions