Skip to content

feat: new connection wizard#1690

Merged
rolznz merged 14 commits into
masterfrom
feat/connection-wizard
Sep 15, 2025
Merged

feat: new connection wizard#1690
rolznz merged 14 commits into
masterfrom
feat/connection-wizard

Conversation

@rolznz
Copy link
Copy Markdown
Member

@rolznz rolznz commented Sep 5, 2025 •
edited by im-adithya
Loading

Closes #1644

  • add dynamic stepper component
  • move connection created into new app flow
  • fix alby go app (superuser should go in new app flow, convert alby go back to a non-custom app)
  • update guides for all suggested apps
  • simpler scope group picker
  • test all flows
    • 1-click connection flow with redirect
    • 1-click connection flow without redirect
    • 1-click connection flow with app pubkey set
    • 1-click connection flow with app store id in metadata
    • normal flow - app store app
    • normal flow - internal app (e.g. BuzzPay)
    • normal flow - custom app
  • test mobile UX

@im-adithya im-adithya mentioned this pull request Sep 10, 2025
Merged
@im-adithya
Copy link
Copy Markdown
Member

im-adithya commented Sep 10, 2025

I'm wondering if internal apps should even have a Connect to APP_NAME button in the top right, since we already do the NWC creation in the page itself.

@im-adithya im-adithya marked this pull request as ready for review September 10, 2025 11:07
@im-adithya
Copy link
Copy Markdown
Member

im-adithya commented Sep 10, 2025

Should we use <ResponsiveButton/> for the connect button?

Apart from that the mobile UX looks 👌

@rolznz
Copy link
Copy Markdown
Member Author

rolznz commented Sep 13, 2025

I'm wondering if internal apps should even have a Connect to APP_NAME button in the top right, since we already do the NWC creation in the page itself.

That should be the case already - they either hide the button or override it. What app was this for?

rolznz
rolznz commented Sep 15, 2025
View reviewed changes
Comment thread frontend/src/components/connections/SuggestedAppData.tsx Outdated
@rolznz
Copy link
Copy Markdown
Member Author

rolznz commented Sep 15, 2025

@im-adithya oops, I somehow removed that by accident. Now most of the internal apps don't have a button on the top right.

@rolznz rolznz changed the title feat: new connection wizard (WIP) feat: new connection wizard Sep 15, 2025
@rolznz rolznz requested a review from reneaaron September 15, 2025 06:01
@rolznz
Copy link
Copy Markdown
Member Author

rolznz commented Sep 15, 2025

@im-adithya nice changes, the new scopes selector looks great 🙌

@rolznz rolznz merged commit 92c6b54 into master Sep 15, 2025
11 checks passed
@rolznz rolznz deleted the feat/connection-wizard branch September 15, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reneaaron reneaaron Awaiting requested review from reneaaron

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New Connection Wizard

2 participants

@rolznz @im-adithya