fix(ui): enable keyboard submission for dialogs #760#2005
Merged
Conversation
rolznz
reviewed
Jan 7, 2026
7a628a2 to
6a6aecb
Compare
rolznz
approved these changes
Jan 12, 2026
Member
rolznz
left a comment
There was a problem hiding this comment.
tACK
There was an issue with the routing fee dialog I fixed. I guess you didn't test this one (needs a public channel)
I made some other fixes too, and removed some unused code.
Contributor
Author
|
Thanks for the merge! And nice catch on the routing fee dialog, i couldn't verify that one locally, so i appreciate you fixing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #760
Fixes #1976
This PR improves accessibility and UX by ensuring that dialogs with input fields can be submitted using the
Enterkey. Previously, users were required to manually click the "Confirm" button.Changes
<form>element across multiple dialog components.onSubmithandlers to trigger the confirm action via keyboard.type="submit".Files Updated
ResetRoutingDataDialogContent.tsxRoutingFeeDialogContent.tsxExecuteCustomNodeCommandDialogContent.tsxDebugTools.tsx(FixedProbeInvoice,ProbeKeysend,RefundSwap,GetLogs, andGetNetworkGraphdialogs)