getantibody · caarlos0 · Sep 3, 2020 · Sep 2, 2020 · Sep 2, 2020 · Sep 2, 2020
diff --git a/Makefile b/Makefile
@@ -24,7 +24,7 @@ cover: test
 
 # Run all the linters
 lint:
-	./bin/golangci-lint run --disable godox --disable wsl --disable gomnd --disable testpackage --disable gofumpt --disable godot --enable-all ./...
+	./bin/golangci-lint run --disable godox --disable wsl --disable gomnd --disable testpackage --disable gofumpt --disable godot --disable nlreturn --enable-all ./...
 .PHONY: lint
 
 # Run all the tests and code checks

diff --git a/README.md b/README.md
@@ -40,6 +40,7 @@ Documentation can be found at https://getantibody.github.io
 - @davidkna's [dotfiles](https://github.com/davidkna/dotfiles);
 - @sobolevn's [dotfiles](https://github.com/sobolevn/dotfiles);
 - @jesseleite's [dotfiles](https://github.com/jesseleite/dotfiles);
+- @mattmc3's [dotfiles](https://github.com/mattmc3/zdotdir/tree/antibody)
 - and probably [many others](https://github.com/search?q=antibody&type=Code);
 
 ## Thanks

diff --git a/project/git.go b/project/git.go
@@ -27,7 +27,7 @@ func NewClonedGit(home, folderName string) Project {
 	folderPath := filepath.Join(home, folderName)
 	version, err := branch(folderPath)
 	if err != nil {
-		version = "master"
+		version = ""
 	}
 	url := folder.ToURL(folderName)
 	return gitProject{
@@ -45,7 +45,7 @@ const (
 // NewGit A git project can be any repository in any given branch. It will
 // be downloaded to the provided cwd
 func NewGit(cwd, line string) Project {
-	version := "master"
+	version := ""
 	inner := ""
 	parts := strings.Split(line, " ")
 	for _, part := range parts {
@@ -91,13 +91,16 @@ func (g gitProject) Download() error {
 	defer lock.Unlock()
 	if _, err := os.Stat(g.folder); os.IsNotExist(err) {
 		// #nosec
-		var cmd = exec.Command("git", "clone",
+		args := []string{
+			"clone",
 			"--recursive",
 			"--depth", "1",
-			"-b", g.Version,
-			g.URL,
-			g.folder,
-		)
+		}
+		if g.Version != "" {
+			args = append(args, "-b", g.Version)
+		}
+		args = append(args, g.URL, g.folder)
+		var cmd = exec.Command("git", args...)
 		cmd.Env = gitCmdEnv
 
 		if bts, err := cmd.CombinedOutput(); err != nil {
@@ -115,12 +118,15 @@ func (g gitProject) Update() error {
 		return err
 	}
 	// #nosec
-	cmd := exec.Command(
-		"git", "pull",
+	args := []string{
+		"pull",
 		"--recurse-submodules",
 		"origin",
-		g.Version,
-	)
+	}
+	if g.Version != "" {
+		args = append(args, g.Version)
+	}
+	cmd := exec.Command("git", args...)
 	cmd.Env = gitCmdEnv
 
 	cmd.Dir = g.folder

diff --git a/project/git_test.go b/project/git_test.go
@@ -36,7 +36,7 @@ func TestDownloadAllKinds(t *testing.T) {
 
 func TestDownloadSubmodules(t *testing.T) {
 	var home = home()
-	var proj = NewGit(home, "fribmendes/geometry")
+	var proj = NewGit(home, "fribmendes/geometry branch:master")
 	var module = filepath.Join(proj.Path(), "lib/zsh-async")
 	require.NoError(t, proj.Download())
 	require.NoError(t, proj.Update())