Refactor: remove Vue Pro features page and update routing by Aunshon · Pull Request #2930 · getdokan/dokan

Aunshon · 2025-10-07T10:59:45Z

Changes proposed in this Pull Request:

Remove pro feature vue codes.

Closes

Closes https://github.com/getdokan/plugin-internal-tasks/issues/959

How to test the changes in this Pull Request:

Check ld pro feature page and check if anything breaks for this pr.

Changelog entry

Not needed

Summary by CodeRabbit

Chores
- Removed the PRO Features item from the admin toolbar.
- Removed the PRO Features submenu from the admin menu.
- Removed the Premium page and its admin route, eliminating the promotional/upgrade screens.

coderabbitai · 2025-10-07T10:59:58Z

Walkthrough

Removes the Premium/PRO UI: deletes the Vue Premium.vue page, unregisters the /premium SPA route, and removes the PRO Features admin toolbar/menu entries. Other admin menus, routes, and public APIs remain unchanged.

Changes

Cohort / File(s)	Summary of changes
Admin toolbar & menu (PHP) `includes/Admin/AdminBar.php`, `includes/Admin/Menu.php`	Removed the commented/conditional additions of the “PRO Features” / `dokan-pro-features` admin toolbar item and the conditional “PRO Features” submenu for non‑Pro installs; other menu items unchanged.
SPA assets / routes (PHP) `includes/Assets.php`	Removed the Vue SPA admin route registration for path `/premium` from `gets_vue_admin_routes`.
Vue Premium page removal `src/admin/pages/Premium.vue`	Deleted the `Premium.vue` single-file component (template, script, styles, data, methods, imports).
Admin router (JS) `src/admin/router/index.js`	Disabled/commented out the Premium route import and its `dokan_add_route` registration; Premium is no longer registered in the admin router.

Sequence Diagram(s)

sequenceDiagram
    actor AdminUser as Admin User
    participant SPA as Admin SPA Router
    participant Menu as PHP Admin Menu
    participant Toolbar as Admin Toolbar

    AdminUser->>Menu: Request admin menu
    Menu-->>AdminUser: Menu without "PRO Features"
    AdminUser->>Toolbar: Request admin toolbar
    Toolbar-->>AdminUser: Toolbar without "PRO Features"
    AdminUser->>SPA: Navigate to /premium
    Note right of SPA: Route removed/disabled
    SPA-->>AdminUser: 404 or redirect (no Premium component)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Enhance: dokan plugin header logo banner icon enhancement #2513 — Also modifies admin menu logic in includes/Admin/Menu.php and relates to submenu handling.
Dashboard card, minicard and month picker component. (Base PR) #2789 — Touches admin navigation/assets and overlaps with admin toolbar and route changes.

Suggested labels

Dev Review Done

Suggested reviewers

mrabbani

Poem

A rabbit nibble, soft and quick,
Snipped the Premium page—clean and slick.
Menus lighter, routes set free,
Hops and carrots, joy for me.
Thump-thump code, a tiny trick. 🐰

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request description includes a brief summary of the proposed change and closes the relevant issue, but it omits the required checklist of standards and testing items, lacks the recommended Related Pull Request(s) section with links, and does not provide Before/After change details as specified by the repository template.	Please update the description to include the top-level checklist for coding standards and testing, add a Related Pull Request(s) section linking PR #2825, and supply Before and After change descriptions to fully adhere to the repository’s template.
Linked Issues Check	❓ Inconclusive	The changes correctly remove all Vue Pro feature code in line with issue #959, but the PR does not explicitly verify that the React replacement from PR #2825 is available prior to removal, leaving a dependency unconfirmed within this changeset.	Please confirm that PR #2825 or equivalent React-based Pro feature implementation is already merged into the target branch before proceeding with this removal to avoid breaking the feature.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The pull request title clearly describes the removal of the Vue Pro features page and accompanying routing updates, matching the main changes in the codebase without extraneous details or noise.
Out of Scope Changes Check	✅ Passed	All file modifications directly relate to removing the Vue Pro features page and its associated routes or menu entries, and no unrelated or extraneous code changes are present in this pull request.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch update/remove-vue-pro-page

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 779638e and 7d495ef.

📒 Files selected for processing (1)

src/admin/router/index.js (0 hunks)

💤 Files with no reviewable changes (1)

src/admin/router/index.js

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: e2e tests (2, 3)
GitHub Check: e2e tests (3, 3)
GitHub Check: api tests (1, 1)
GitHub Check: e2e tests (1, 3)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fe18fba and 779638e.

⛔ Files ignored due to path filters (23)

assets/images/premium/Cédric-Lefrancq.jpeg is excluded by !**/*.jpeg
assets/images/premium/Morten-J.-Christensen.jpg is excluded by !**/*.jpg
assets/images/premium/available@2x.png is excluded by !**/*.png
assets/images/premium/cedric-lefrancq.jpeg is excluded by !**/*.jpeg
assets/images/premium/david-gaz.jpeg is excluded by !**/*.jpeg
assets/images/premium/dokan-lite-logo@2x.png is excluded by !**/*.png
assets/images/premium/dokan-pro-logo@2x.png is excluded by !**/*.png
assets/images/premium/gaurantee-thumb.png is excluded by !**/*.png
assets/images/premium/header-feature-thumb@2x.png is excluded by !**/*.png
assets/images/premium/melissa.jpg is excluded by !**/*.jpg
assets/images/premium/payment-options.png is excluded by !**/*.png
assets/images/premium/quote-icon.png is excluded by !**/*.png
assets/images/premium/service-01@2x.png is excluded by !**/*.png
assets/images/premium/service-02@2x.png is excluded by !**/*.png
assets/images/premium/service-03@2x.png is excluded by !**/*.png
assets/images/premium/service-04@2x.png is excluded by !**/*.png
assets/images/premium/service-05@2x.png is excluded by !**/*.png
assets/images/premium/service-06@2x.png is excluded by !**/*.png
assets/images/premium/service-07@2x.png is excluded by !**/*.png
assets/images/premium/service-08@2x.png is excluded by !**/*.png
assets/images/premium/service-09@2x.png is excluded by !**/*.png
assets/images/premium/unavailable@2x.png is excluded by !**/*.png
assets/images/premium/view-icon@2x.png is excluded by !**/*.png

📒 Files selected for processing (5)

includes/Admin/AdminBar.php (0 hunks)
includes/Admin/Menu.php (0 hunks)
includes/Assets.php (0 hunks)
src/admin/pages/Premium.vue (0 hunks)
src/admin/router/index.js (2 hunks)

💤 Files with no reviewable changes (4)

includes/Assets.php
includes/Admin/AdminBar.php
src/admin/pages/Premium.vue
includes/Admin/Menu.php

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: e2e tests (2, 3)
GitHub Check: e2e tests (3, 3)
GitHub Check: e2e tests (1, 3)
GitHub Check: api tests (1, 1)

src/admin/router/index.js

refactor: remove Vue Pro features page and update routing

779638e

Aunshon self-assigned this Oct 7, 2025

Aunshon added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval labels Oct 7, 2025

coderabbitai bot reviewed Oct 7, 2025

View reviewed changes

src/admin/router/index.js Outdated Show resolved Hide resolved

mrabbani requested changes Oct 14, 2025

View reviewed changes

src/admin/router/index.js Outdated Show resolved Hide resolved

mrabbani added Needs: Author Reply and removed Needs: Dev Review It requires a developer review and approval labels Oct 14, 2025

refactor: remove Premium page and associated routing in admin panel

7d495ef

Aunshon added Needs: Dev Review It requires a developer review and approval and removed Needs: Author Reply labels Oct 14, 2025

mrabbani approved these changes Oct 20, 2025

View reviewed changes

mrabbani added Dev Review Done and removed Needs: Dev Review It requires a developer review and approval labels Oct 20, 2025

dev-shahed added 🎉 QA Approved This PR is approved by the QA team and removed Needs: Testing This requires further testing labels Oct 20, 2025

mrabbani added the Upcoming Release label Oct 22, 2025

MdAsifHossainNadim merged commit effa248 into develop Oct 22, 2025
1 of 6 checks passed

MdAsifHossainNadim deleted the update/remove-vue-pro-page branch October 22, 2025 06:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor: remove Vue Pro features page and update routing#2930

Refactor: remove Vue Pro features page and update routing#2930
MdAsifHossainNadim merged 2 commits intodevelopfrom
update/remove-vue-pro-page

Aunshon commented Oct 7, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Oct 7, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Aunshon commented Oct 7, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this Pull Request:

Closes

How to test the changes in this Pull Request:

Changelog entry

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Aunshon commented Oct 7, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 7, 2025 •

edited

Loading