[scheduler] add example of using Scheduler from Java#1121
Merged
Conversation
hearnadam
commented
Mar 30, 2025
Comment on lines
+23
to
+26
| scheduler.schedule(Task.apply(() -> { | ||
| threadName.set(Thread.currentThread().getName()); | ||
| latch.countDown(); | ||
| })); |
Collaborator
Author
There was a problem hiding this comment.
Perhaps we should add a Function1 overload to Task.apply. Currently this is lifting to Runnable.
We could also add some overloads for task scheduling to the Scheduler itself.
Collaborator
There was a problem hiding this comment.
I think Runnable is important to support because it's typically what people already have when invoking the scheduler. If we go with Scala's Function1 instead, it could require an extra wrapper allocation to adapt
fwbrasil
reviewed
Mar 30, 2025
| AtomicReference<String> threadName = new AtomicReference<>(""); | ||
| CountDownLatch latch = new CountDownLatch(1); | ||
|
|
||
| scheduler.schedule(Task.apply(() -> { |
Collaborator
There was a problem hiding this comment.
cool! I wasn't expecting the Scala API to work this well from Java
fwbrasil
approved these changes
Mar 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Scheduler is currently published as a Scala module, so I suspect users may not realize that it's available for other JVM applications.
#1111
Solution
Add an example test in Java to make sure our APIs are always accessible from Java - not depending on Scala specific features.