Render the error page on invalid media URLs#3202
Conversation
More consistent behavior that also allows overriding the error behavior with custom code on the error page. Fixes https://forum.getkirby.com/t/adjusting-the-media-hash-generation/21456/14?u=lukasbestle.
|
Wondering whether this could be a breaking change for some setups - (for whatever reason) checking for text/plain on error responses but now getting HTML. |
|
I don‘t think so. We previously had |
|
Having looked at it again, you're right: I think it's a good change that won't really cause issues anywhere. Questions is if this is urgent or could wait until 3.6.0 since strictly it's a breaking change (public method returns something different now) - one that won't break many (if any) actual setups though. |
|
You are right, it's probably better to move this to 3.6.0. Marking it as draft to avoid that we merge it by accident. The code is already done. |
Describe the PR
More consistent behavior that also allows overriding the error behavior with custom code on the error page.
Related issues
Ready?
composer cilocally)Running locally requires PHPUnit, PHP-CS-Fixer, Psalm, PHPCPD and PHPMD.