Summary

Re-runs potion-skill-generator against the full monorepo to produce an up-to-date, tailored Claude Code skill pack at .claude/. Replaces the prior generation (skills already prefixed potion-, but agents and module notes were stale).

Inputs digested: 61 modules explored, 80 human PR review comments mined, 28 contrib/claude/*.md docs absorbed.

What changed

Skills (.claude/skills/): /potion-ask, /potion-plan, /potion-implement, /potion-review, /potion-learn (new — mines getprobo/probo PR reviews, detects drift between contrib/claude/ and code, stages guideline updates).

Agents (.claude/agents/): All renamed to potion- prefix.

• Generalists: potion-explorer, potion-planner, potion-implementer, potion-reviewer
• Stack-specific implementers: potion-go-backend-implementer, potion-typescript-frontend-implementer (each loads only its stack's guidelines for focused context)
• Specialized reviewers (.claude/agents/reviewers/): architecture, pattern, security, style, test, duplication, plus opt-in adversarial reviewer wired to OpenAI Codex via the local Codex MCP server

Guidelines (.claude/guidelines/): 3,921 lines, 35 files in a multi-stack tree.

• shared.md — cross-cutting: four-surface API rule (GraphQL ↔ MCP ↔ CLI ↔ n8n), GIDs, ISC headers, git workflow, security baseline, 19 PR-review-enforced standards distilled from human reviewer comments
• go-backend/ — patterns, conventions, testing, pitfalls + 19 module notes (one per package group)
• typescript-frontend/ — same shape + 10 module notes

AGENTS.md gains a top-of-file section pointing to the skill pack while keeping contrib/claude/ as the authoritative source-of-truth.

.gitignore now excludes the local .skill-gen-workspace/ and .claude_context caches.

Why

The four-surface API rule (GraphQL ↔ MCP ↔ CLI ↔ n8n) is the rule most likely to be silently dropped by an AI assistant lacking Probo context. The potion-implement skill enforces it before delegating; the with/without evaluation showed a vanilla agent literally said "MCP/CLI/n8n not on critical path" while the skill-loaded agent generated concrete diffs across all four surfaces.

Other measurable wins from the with/without comparison:

• potion-plan turns prior-art discovery into a AskUserQuestion decision (Route A reuse vs Route B new entity) per skill methodology
• potion-review enforces severity categorization + cites guideline section numbers + caught the license year-range rule that vanilla missed
• potion-ask followed the lazy-loading order exactly and structured failure modes by category

Test plan

• git diff --stat origin/main shows only .claude/, AGENTS.md, and .gitignore changes
• /potion-ask "where is tenant isolation enforced" loads shared.md then go-backend/index.md then drills into module-notes/coredata.md
• /potion-plan "add an AuditTrail entity" surfaces the existing AuditLogEntry as Route A
• /potion-implement "add a pendingActionsCount field" routes to potion-go-backend-implementer and produces concrete diffs across all four surfaces
• /potion-review "review pkg/agent/tools/search/web_search.go" flags bare http.Client{} as a security blocker citing shared.md §12
• /potion-review "second opinion on this PR" triggers the adversarial reviewer (requires Codex CLI + ChatGPT login or OPENAI_API_KEY)
• AGENTS.md renders correctly on GitHub

Summary by cubic

Regenerated the Probo skill pack under .claude/ with multi-stack guidelines and potion-‑prefixed skills/agents, plus an opt-in adversarial reviewer via Codex MCP. Planning, implementation, and reviews are now stack‑aware and enforce the four‑surface API rule across GraphQL ↔ MCP ↔ CLI ↔ n8n.

• New Features

  • Skills: /potion-ask, /potion-plan, /potion-implement, /potion-review, /potion-learn (mines PR reviews, detects guideline drift).
  • Agents: generalists (potion-explorer, potion-planner, potion-implementer, potion-reviewer), stack implementers (potion-go-backend-implementer, potion-typescript-frontend-implementer), and reviewers (architecture, pattern, security, style, test, duplication, potion-adversarial-reviewer via Codex MCP); all potion-‑prefixed.
  • Guidelines: .claude/guidelines/shared.md plus go-backend/ and typescript-frontend/ trees with module notes; reference contrib/claude/.

• Migration

  • No product code changes; only .claude/, AGENTS.md (points to the pack), and .gitignore (ignores .skill-gen-workspace/ and .claude_context).
  • Adversarial reviewer requires the Codex CLI and either codex login or OPENAI_API_KEY.

^{Written for commit 9755b29. Summary will update on new commits.}