Add macro to check for broken symlinks in installdir#62
Merged
Conversation
1 task
ermo
reviewed
Feb 25, 2024
Contributor
ermo
left a comment
There was a problem hiding this comment.
Smart money is on ensuring that this is also landed in the python3 version of ypkg...
Signed-off-by: Thomas Staudinger <Staudi.Kaos@gmail.com>
1bde3ce to
c929d8c
Compare
ermo
approved these changes
Feb 27, 2024
Contributor
ermo
left a comment
There was a problem hiding this comment.
LGTM!
Still think it would be wise to have an identical PR for eopkg py3, but that shouldn't stop this PR from getting merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the %symlink_check macro to look for and exit on finding broken symlinks.
Exporting SYMLINK_WARN will make it just print the broken symlinks and warning message without halting the package build.