Skip to content

yupdate: Only update the first element in list#83

Merged
joebonrichie merged 1 commit into
masterfrom
yupdate-no-nukey
Jun 23, 2024
Merged

yupdate: Only update the first element in list#83
joebonrichie merged 1 commit into
masterfrom
yupdate-no-nukey

Conversation

@joebonrichie
Copy link
Copy Markdown
Contributor

@joebonrichie joebonrichie commented Jun 23, 2024

If additional sources exist don't nuke them. This is the behaviour we want the vast majority of the time.

test case: yupdate 24.06.0 https://poppler.freedesktop.org/poppler-24.06.0.tar.xz

before

diff --git a/packages/p/poppler/package.yml b/packages/p/poppler/package.yml
index 2ef4d4047b..67c08f43af 100644
--- a/packages/p/poppler/package.yml
+++ b/packages/p/poppler/package.yml
@@ -1,9 +1,8 @@
 name       : poppler
-version    : 24.04.0
-release    : 49
+version    : 24.06.0
+release    : 50
 source     :
-    - https://poppler.freedesktop.org/poppler-24.04.0.tar.xz : 1e804ec565acf7126eb2e9bb3b56422ab2039f7e05863a5dfabdd1ffd1bb77a7
-    - git|https://gitlab.freedesktop.org/poppler/test.git : 400f3ff05b2b1c0ae17797a0bd50e75e35c1f1b1
+    - https://poppler.freedesktop.org/poppler-24.06.0.tar.xz : 0cdabd495cada11f6ee9e75c793f80daf46367b66c25a63ee8c26d0f9ec40c76
 homepage   : http://poppler.freedesktop.org/
 license    : GPL-2.0-or-later
 component  :

now

diff --git a/packages/p/poppler/package.yml b/packages/p/poppler/package.yml
index 2ef4d4047b..17593b8f42 100644
--- a/packages/p/poppler/package.yml
+++ b/packages/p/poppler/package.yml
@@ -1,8 +1,8 @@
 name       : poppler
-version    : 24.04.0
-release    : 49
+version    : 24.06.0
+release    : 50
 source     :
-    - https://poppler.freedesktop.org/poppler-24.04.0.tar.xz : 1e804ec565acf7126eb2e9bb3b56422ab2039f7e05863a5dfabdd1ffd1bb77a7
+    - https://poppler.freedesktop.org/poppler-24.06.0.tar.xz : 0cdabd495cada11f6ee9e75c793f80daf46367b66c25a63ee8c26d0f9ec40c76
     - git|https://gitlab.freedesktop.org/poppler/test.git : 400f3ff05b2b1c0ae17797a0bd50e75e35c1f1b1
 homepage   : http://poppler.freedesktop.org/
 license    : GPL-2.0-or-later

Notice how the additional source doesn't get nuked.

@joebonrichie
yupdate: Only update the first element in list
e06cb91 
If additional sources exist don't nuke them. This is the behaviour we
want the vast majority of the time.
ermo
ermo approved these changes Jun 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice bugfix. Let's get it in.

@joebonrichie joebonrichie merged commit d383f0c into master Jun 23, 2024
@joebonrichie joebonrichie deleted the yupdate-no-nukey branch June 23, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ermo ermo ermo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joebonrichie @ermo