Fix Artist theme: remove incorrect directory and add as proper submodule #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Artist theme was incorrectly placed in themes/artist instead of being a proper submodule at the root level. This commit removes the misplaced directory and adds the theme as a submodule from the correct repository.
Collaborator
|
It will automatically do a PR on Zola with the output (if i remember correctly) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this PR fixes the Artist theme which was incorrectly placed in a nested folder (sorry!):
themes/artist(creatingthemes/themes/artistfrom the repo root) instead of being added as a proper submoduleThe theme is now properly configured as a submodule at the root
Artist/directory.If you could take a look and verify that Artist in the right place to appear on the themes site, that'd be a big help for me. I haven't been able to generate the themes site locally. When I run
python generate_docs.py DESTINATION_FOLDER, I just see an empty_index.mdin DESTINATION_FOLDER, and so I'm not sure how to preview the themes page. Thank you!