Skip to content

Using default nsview if not provided by raw-window-handle #3329

Description

@aclysma

Short info header:

  • GFX version: gfx-backend-metal 0.5.6
  • OS: macOS
  • GPU: 5700 XT

Would it make sense to apply this change https://github.com/gfx-rs/wgpu/pull/462/files in wgpu to Instance::create_surface?

I am hitting this when adding SDL2 as a backend to bevy.

Activity

  1. kvark commented on Aug 12, 2020

    @kvark
    Member

    Yes, that would make sense

  2. added a commit that references this issue on Aug 12, 2020
    5fa0044
  3. aclysma commented on Aug 12, 2020

    @aclysma
    Author

    I wasn't sure what branch to put this on. bevy looks like it's using 0.5, and I only applied the change to that branch but only macOS since that's what I'm testing on. This looks like it resolves the issue for me but not sure how you want to proceed with upstreaming this fix.

  4. msiglreith commented on Aug 12, 2020

    @msiglreith
    Contributor

    fyi I extracted the conversion process for Metal out in a separate crates (https://github.com/norse-rs/raw-window-metal) for ash-window which might come in handy here. It walks through the handle and tries to retrieve or allocate a CAMetalLayer out of it.

  5. kvark commented on Aug 12, 2020

    @kvark
    Member

    Let's use it then!

  6. cart commented on Aug 16, 2020

    @cart

    Bevy has a 0.6.0 wgpu master branch here you can test on: https://github.com/bevyengine/bevy/commits/wgpu_upgrade

    We should focus on supporting that given how close 0.6.0 is.

  7. pinned this issue on Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions