Skip to content

Fixed bug seen on deleting the user name in the UI. #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericbsd merged 1 commit into from
Nov 16, 2024
Merged

Fixed bug seen on deleting the user name in the UI. #78

ericbsd merged 1 commit into from
Nov 16, 2024

Conversation

@ericbsd
Copy link
Member

@ericbsd ericbsd commented Nov 16, 2024 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

Bug Fixes:

  • Fix issue where deleting the user name in the UI did not clear the host and user fields.

@ericbsd ericbsd requested review from a team as code owners November 16, 2024 16:26
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 16, 2024 •
edited
Loading

Reviewer's Guide by Sourcery

The PR fixes a bug in the user interface where deleting the username would cause an IndexError. The implementation adds a length check before accessing the username array and clears both the host and user fields when the username is empty.

Sequence diagram for handling empty username input

sequenceDiagram
    actor User
    participant UI
    participant Backend

    User->>UI: Delete username
    UI->>Backend: Check username length
    alt Username is empty
        Backend->>UI: Clear host and user fields
    else Username is not empty
        Backend->>UI: Set host and user fields
    end
Loading

File-Level Changes

Change Details Files
Added input validation and proper handling of empty username
  • Added a length check before accessing the username array
  • Clear host and user fields when username is empty
  • Updated string formatting to use f-strings
  • Fixed potential IndexError when username is deleted
 src/add_admin.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Nov 16, 2024
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericbsd - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericbsd ericbsd merged commit a437ea4 into master Nov 16, 2024
2 checks passed
@ericbsd ericbsd deleted the fix-partiotn.py branch November 16, 2024 16:42
@ericbsd ericbsd self-assigned this Nov 16, 2024
@ericbsd ericbsd added the bug label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

@ericbsd ericbsd

Labels

bug

Projects

Development Tracker
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericbsd