macOS: use NSDockTilePlugIn to update app icons
#9983
+593
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e92e17d to
2fddd93
Compare
e8b34c8 to
db5f7bd
Compare
db5f7bd to
fa6e581
Compare
fa6e581 to
c6944dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using MAP prohibited
NSDockTilePlugInto update custom icons more reliably. And it also fixes the corner radius issue on older os: #8870Warning
Upgrading from
macOS-custom-iconneeds to manually open the app once to update the icon, since this plugin is running undercom.apple.dock.external.extra.arm64, which has sandbox enabled.When first upgraded to this commit, a notification about the dock plugin will pop up. The user has to enable this to change the icon smoothly.
Here are the testing results on Tahoe and Sequoia:
This also fixes some issues when changing between different styles, consistency issues, and resetting from others to
official.Developer's Note
This shouldn't affect current CI flow, since this new target is just a bundle not runnable, and I tested with archiving, exporting and signing in Xcode, nothing big changed.
Note
AI helped me to write the typo ignore-re and proofread my comments