Skip to content

Conversation

@cbarraford
Copy link

the cache interferes with gin CORS, setting the headers twice (once by cache and once by cors), which is invalid.

Thanks to 0987363@1882a7e

@codecov-io
Copy link

codecov-io commented Feb 8, 2018

Codecov Report

Merging #20 into master will decrease coverage by 5.51%.
The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   71.79%   66.27%   -5.52%     
==========================================
  Files           1        1              
  Lines          78       86       +8     
==========================================
+ Hits           56       57       +1     
- Misses         20       27       +7     
  Partials        2        2
Impacted Files Coverage Δ
cache.go 66.27% <12.5%> (-5.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f25cc...d1dc2ca. Read the comment docs.

@hashworks
Copy link
Contributor

I think this can be closed with #38.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants