Skip to content

Add CustomRecovery builtin middleware #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thinkerou merged 6 commits into from
Jul 9, 2020
Merged

Add CustomRecovery builtin middleware #2322

thinkerou merged 6 commits into from
Jul 9, 2020

Conversation

@theonlyjohnny
Copy link
Contributor

@theonlyjohnny theonlyjohnny commented Apr 16, 2020

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as TravisCI.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

CustomRecovery allows the user to control what happens in the case of a panic without having to re-implement the Recovery middleware

@codecov
Copy link

codecov bot commented Apr 16, 2020 •
edited
Loading

Codecov Report

Merging #2322 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2322   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files          41       41           
  Lines        2348     2356    +8     
=======================================
+ Hits         2318     2326    +8     
  Misses         17       17           
  Partials       13       13
Impacted Files Coverage Δ
recovery.go 97.50% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e40c1d...5782c13. Read the comment docs.

@theonlyjohnny
Copy link
Contributor Author

theonlyjohnny commented Apr 25, 2020

👋 Could I get a maintainer's 👀 on this plz? Currently using my fork and would like to not have to

appleboy
appleboy reviewed Jun 11, 2020
View reviewed changes
@appleboy appleboy added this to the 1.7 milestone Jun 11, 2020
@appleboy appleboy requested review from appleboy and thinkerou June 27, 2020 02:31
thinkerou
thinkerou approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thinkerou thinkerou merged commit 4cabdd3 into gin-gonic:master Jul 9, 2020
@elftech
Copy link

elftech commented Jan 16, 2021

why still no CustomRecovery in the recovery.go when I download v1.6.3 using go module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appleboy appleboy appleboy approved these changes

@thinkerou thinkerou thinkerou approved these changes

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

v1.7

Development

Successfully merging this pull request may close these issues.

4 participants

@theonlyjohnny @elftech @appleboy @thinkerou