Skip to content

Small changes for basis, knot vector, domain iterator#712

Merged
hverhelst merged 7 commits into
stablefrom
single_eval_and_co
Jan 6, 2025
Merged

Small changes for basis, knot vector, domain iterator#712
hverhelst merged 7 commits into
stablefrom
single_eval_and_co

Conversation

@hverhelst

@hverhelst hverhelst commented May 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

NEW:
Paraview write for boxes represented by matrices
Nestedness check of knot vector
Extra constructor for gsTensorDomainBoundaryIterator

IMPROVED:

FIXED:
ID of gsTensorDomainIterator

API:
Make gsBasis<T>::evalAllDersSingle_into with argument gsMatrix<T> & deprecated, and add gsBasis<T>::evalAllDersSingle_into with argument std::vector<gsMatrix<T>> in line with evalAllDers_into. Only gsBSplineBasis::evalAllDersSingle_into overloads, but throws a warning for a bug anyways.

Please consider the following checklist before issuing a pull
request:

  • Have you added an explanation of what your changes do and why
    you'd like us to include them?
  • Have you documented any new codes using Doxygen comments?
  • Have you written new tests or examples for your changes?

@hverhelst
Add evaluation of single basis function
674de66 
Add paraview write for boxes represented by matrices
Add nestedness check of knot vector
Add extra constructor for `gsTensorDomainBoundaryIterator`
FIX ID of `gsTensorDomainIterator`
@hverhelst hverhelst requested review from a team and filiatra as code owners May 16, 2024 17:38
filiatra
filiatra requested changes Jun 7, 2024
View reviewed changes

@filiatra filiatra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is the function:

gsBasisFun function(index_t i) const

that can be used to get a handle on a single basis function.
This should do the same as "computesingle".

Can you tryto use that and if it works the same, remove computeSinge ?
it looks a bit of duplicated functionality.

hverhelst
hverhelst commented Jul 5, 2024
View reviewed changes

@hverhelst hverhelst left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reverted the computeSingle. There is still the evalAllDersDingle_into, but that one provides an implementation of an existing function with that name using different input arguments.

@hverhelst hverhelst requested a review from filiatra July 7, 2024 07:43
@hverhelst hverhelst added this to the v24.12.0 milestone Dec 3, 2024
@hverhelst hverhelst self-assigned this Dec 3, 2024
@hverhelst
make evalAllDersSingle_into returning gsMatrix<T> & deprecated,
fe6c413 
better is to use the version with `std::vector<gsMatrix<T>>`.
The only use of `evalAllDersSingle_into` is inside `gsBSplineBasis`,
which throws a bug warning.
@hverhelst
Merge remote-tracking branch 'origin/stable' into single_eval_and_co
c56e38a
@hverhelst

hverhelst commented Dec 20, 2024

Copy link
Copy Markdown
Member Author

I have checked this PR again, @filiatra could you have a look.
One improvement would be to replace the gsWriteParaview function for boxes to a version where they are not written in nBoxes number of files, but instead just in one file (with an unstructured grid or so. I don't know yet which type to use in Paraview.

@hverhelst hverhelst merged commit ecd3ccb into stable Jan 6, 2025
@hverhelst hverhelst deleted the single_eval_and_co branch January 6, 2025 12:40
@BrewTestBot BrewTestBot mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filiatra filiatra filiatra approved these changes

Assignees

@hverhelst hverhelst

Labels

None yet

Projects

None yet

Milestone

v24.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@hverhelst @filiatra