Skip to content

Conversation

@SIkebe
Copy link
Member

@SIkebe SIkebe commented Oct 6, 2020

Before submitting a pull-request to GitBucket I have first:

  • read the contribution guidelines
  • rebased my branch over master
  • verified that project is compiling
  • verified that tests are passing
  • squashed my commits as appropriate (keep several commits if it is relevant to understand the PR)
  • marked as closed using commit message all issue ID that this PR should correct

Fixes #2553

@takezoe
Copy link
Member

takezoe commented Nov 3, 2020

Redirecting to GitHub Desktop website automatically might not be welcomed in some cases. I think showing a dialog which contains an explanation of the necessity of GitHub Desktop installation and a link to GitHub Desktop website can be an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

"Open with GitHub Desktop" doesn't work if your machine has no associated app

2 participants