Skip to content

Conversation

lpalgarvio
Copy link
Contributor

@lpalgarvio lpalgarvio commented Aug 21, 2025

Reasons for making this change

Add extra rules

Links to documentation supporting these rule changes

Comments

I think these entries should not be here:

  • .Python: looks more of distribution/packaging and present on https://github.com/github/gitignore/blob/main/Global/VirtualEnv.gitignore and i dont think it has anything to do with virtual envs
  • [Bb]in, [Ii]nclude, [Ll]ib, [Ll]ib64, [Ll]ocal, [Ss]cripts: this does not seem to have anything to do with python's virtualenv spec. some of these entries might actually conflict with code in projects, ie, bin and scripts
  • pip-selfcheck.json: not specific to python virtualenv, but rather python dependencies using pip

Perhaps some of them should be moved to https://github.com/github/gitignore/blob/main/Python.gitignore and some entirely removed

@lpalgarvio lpalgarvio requested a review from a team as a code owner August 21, 2025 01:42
@sebastianw
Copy link
Contributor

Just as a note, the docs explicitly say that you should commit .python-version to the repository:

Consider these guidelines when using .python-version files:

  • Pin specific versions for reproducible development environments
  • Commit to version control to ensure team consistency
  • Align with project requirements - ensure the pinned version satisfies requires-python
  • Update thoughtfully when upgrading Python versions across the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants