Skip to content

Conversation

deniz-blue
Copy link

Reasons for making this change

react-router is a widely used library/framework for making routing based react applications. this PR adds react-router v7 framework mode's gitignore folders

Links to documentation supporting these rule changes

React router has added framework mode on v7 which is based on Vite.

React router documentation unfortunately does not mention both of these:

  • .react-router folder houses autogenerated .ts files (per-route) for type checking
  • React router puts build output into the build folder (as opposed to dist with vite)

I have added .react-router into the gitignore but I am unsure about including the build folder. Should I keep it like this, include it or remove it? Currently its commented out (so if anyone needs to, they can uncomment it)

Merge and Approval Steps

  • Confirm that you've read the contribution guidelines and ensured your PR aligns
  • Ensure CI is passing
  • Get a review and Approval from one of the maintainers

@deniz-blue deniz-blue requested a review from a team as a code owner September 11, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant