Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
react-router is a widely used library/framework for making routing based react applications. this PR adds react-router v7 framework mode's gitignore folders
Links to documentation supporting these rule changes
React router has added framework mode on v7 which is based on Vite.
React router documentation unfortunately does not mention both of these:
.react-router
folder houses autogenerated.ts
files (per-route) for type checkingbuild
folder (as opposed todist
with vite)I have added
.react-router
into the gitignore but I am unsure about including thebuild
folder. Should I keep it like this, include it or remove it? Currently its commented out (so if anyone needs to, they can uncomment it)Merge and Approval Steps