sources: replace filetype with mimetype and add explicit human-readable filter #1951
+88
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le filter The old logic skipped all application/* files as binary, which risked ignoring human-readable formats if detection improved. In practice, JSON/YAML/etc. were scanned only because filetype returned "unknown". This change: - uses mimetype for broader and more accurate detection - adds isHumanReadable() to explicitly whitelist text/* and common textual application/* types (json, xml, yaml, toml, js, xhtml) - makes the skip policy explicit instead of relying on "unknown" fallback - adds regression tests to verify classification Additionally, this patch migrates the detection library from `h2non/filetype` to the more accurate and actively maintained `gabriel-vasile/mimetype`. Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The old logic skipped all
application/*files as binary, which risked ignoring human-readable formats if detection improved. In practice, JSON/YAML/etc. were scanned only because filetype returned "unknown".This change:
isHumanReadable()to explicitly whitelisttext/*and common textualapplication/*types (json, xml, yaml, toml, js, xhtml)Additionally, this patch migrates the detection library from
h2non/filetypeto the more accurate and actively maintainedgabriel-vasile/mimetype.Checklist: