New inference script and notebook #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r now, not fully tested
…ve dependency on metl-pretrained
…onger needed to run inference
Member
|
@brycejoh16 you will be a potential user of this. Can you please give the initial review? |
Collaborator
|
@agitter , I can do an initial review and give feedback . |
brycejoh16
approved these changes
May 26, 2025
Collaborator
brycejoh16
left a comment
There was a problem hiding this comment.
Looks good to me, we may just want to use a different parameter for determining source vs target model, such as model_name or a finetuning argument.
…s trained in this repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new inference script and notebook. The notebook shows how to run inference with our Lightning framework or load the model as a PyTorch module and use a custom inference loop. I removed dependencies and references to using the metl-pretrained package for running inference and updated READMEs.