-
Notifications
You must be signed in to change notification settings - Fork 237
fix issue 144 #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue 144 #151
Conversation
|
CI on darwin seems to be broken but not related to the changes in this PR. |
|
Whohoo, cool! Now, the challenge is to make this backwards compatible. Otherwise updating to this version will break existing deployments. Or we have to increase the major version number. |
|
Maybe merge it after #125 |
|
nah ... v2.0.0 has a few breaking changes on the api level ... might make sense to add some fallback code that allows both values and logs an error when the old one is found. it can continue working, but admins should see the error on startup, maybe with a message that says 'encountered deprecated config value, please update your config, support for ... will be dropped in future versions'. |
|
I'm going to have a look into this when I have some time left. |
|
@butonic Done. Please have a look. |
|
Thx for your effort and sorry for letting you wait so long. Life happened. I rebased this on the dev branch. Let's see what CI says now |
|
I've fixed the build. |
This just fixes #144