Skip to content

Conversation

@fgma
Copy link

@fgma fgma commented Sep 8, 2020

This just fixes #144

@fgma
Copy link
Author

fgma commented Sep 8, 2020

CI on darwin seems to be broken but not related to the changes in this PR.

@butonic
Copy link
Collaborator

butonic commented Sep 28, 2020

Whohoo, cool! Now, the challenge is to make this backwards compatible. Otherwise updating to this version will break existing deployments. Or we have to increase the major version number.

@fgma
Copy link
Author

fgma commented Oct 1, 2020

Maybe merge it after #125

@butonic
Copy link
Collaborator

butonic commented Oct 5, 2020

nah ... v2.0.0 has a few breaking changes on the api level ... might make sense to add some fallback code that allows both values and logs an error when the old one is found. it can continue working, but admins should see the error on startup, maybe with a message that says 'encountered deprecated config value, please update your config, support for ... will be dropped in future versions'.

@butonic butonic assigned butonic and unassigned butonic Oct 5, 2020
@butonic butonic added the enhancement New feature or request label Oct 5, 2020
@fgma
Copy link
Author

fgma commented Oct 13, 2020

I'm going to have a look into this when I have some time left.

@fgma
Copy link
Author

fgma commented Oct 17, 2020

@butonic Done. Please have a look.

@butonic butonic changed the base branch from master to dev December 8, 2020 21:19
@butonic
Copy link
Collaborator

butonic commented Dec 8, 2020

Thx for your effort and sorry for letting you wait so long. Life happened.

I rebased this on the dev branch. Let's see what CI says now

@fgma
Copy link
Author

fgma commented Dec 11, 2020

I've fixed the build.

@Fusion
Copy link
Collaborator

Fusion commented Jul 31, 2021

Hi @fgma renewed apologies for the incredibly long delay!

Due to how much the code has drifted since your pull request, unfortunately, I had a create a brand new PR. Would you mind reviewing it? Thanks!

#201

@Fusion
Copy link
Collaborator

Fusion commented Aug 8, 2021

Closing in favor of #201

Thanks, @fgma!

@Fusion Fusion closed this Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uidnumber or unixid?

3 participants