Skip to content

Fixes #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gleero merged 3 commits into from
Dec 5, 2013
Merged

Fixes #12

gleero merged 3 commits into from
Dec 5, 2013

Conversation

@ro-ka
Copy link
Contributor

@ro-ka ro-ka commented Dec 5, 2013

  • Fix naming in error messages ('is not exists' -> 'does not exist')
  • Fix file names in firefox manifest (they were missing a -)

Note for the tests: Maybe it would be better to generate the compare hash from a 'expected' file so it is easier to spot such things.

gleero added a commit that referenced this pull request Dec 5, 2013
@gleero
Merge pull request #12 from ro-ka/fixes
5102806 
oops :)
@gleero gleero merged commit 5102806 into gleero:master Dec 5, 2013
@ro-ka ro-ka deleted the fixes branch December 5, 2013 15:44
@ro-ka
Copy link
Contributor Author

ro-ka commented Dec 5, 2013

Thanks, you're incredible fast! :)

@ro-ka
Copy link
Contributor Author

ro-ka commented Dec 10, 2013

When will these updates come to npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ro-ka @gleero