Skip to content

Fix issue with reference data choices and update attributes#2577

Open
Carifio24 wants to merge 3 commits into
glue-viz:mainfrom
Carifio24:3d-viewer-state-layers-changed
Open

Fix issue with reference data choices and update attributes#2577
Carifio24 wants to merge 3 commits into
glue-viz:mainfrom
Carifio24:3d-viewer-state-layers-changed

Conversation

@Carifio24
Copy link
Copy Markdown
Member

This PR aims to fix #2576 by removing the check on the layers list, while also trying to resolve the issue that the check was put in there to work around. It also makes a couple of other tweaks to the attributes setup. The basic changes are:

  • The reference data dropdown now gets updated on a layers callback
  • x/y/z attribute choices are now set specifically from the reference data
  • We set up default x/y/z attributes for the standard cube pixel coordinate ordering of 2, 1, 0 (currently we are just using 0, 1, 2). I'm not sure if there is any sort of convention for 4D+ cubes, but users can always change attributes anyways

@Carifio24 Carifio24 requested a review from astrofrog March 20, 2026 20:32
@astrofrog
Copy link
Copy Markdown
Member

Thanks! Could you add a regression test?

@Carifio24
Copy link
Copy Markdown
Member Author

@astrofrog I've added a few tests that I think should cover everything here

@Carifio24 Carifio24 added the bug label May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reference data dropdown doesn't update

2 participants