Fix issue with reference data choices and update attributes#2577
Open
Carifio24 wants to merge 3 commits into
Open
Fix issue with reference data choices and update attributes#2577Carifio24 wants to merge 3 commits into
Carifio24 wants to merge 3 commits into
Conversation
…x/y/z and use reference data attributes.
Member
|
Thanks! Could you add a regression test? |
…ression test for reference data choices.
Member
Author
|
@astrofrog I've added a few tests that I think should cover everything here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #2576 by removing the check on the layers list, while also trying to resolve the issue that the check was put in there to work around. It also makes a couple of other tweaks to the attributes setup. The basic changes are:
layerscallback