Skip to content

Add DNS provider for ZoneEdit #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ldez merged 6 commits into from
Jul 12, 2025
Merged

Add DNS provider for ZoneEdit #2578

ldez merged 6 commits into from
Jul 12, 2025

Conversation

@ldez
Copy link
Member

@ldez ldez commented Jul 10, 2025 •
edited
Loading

  • adds a description to your PR
  • have a homogeneous design with the other providers
  • add tests (units)
  • add tests ("live")
  • add a provider descriptor
  • generate CLI help, documentation, and readme.
  • be able to do: (and put the output of this command to a comment) 
    make build
rm -rf .lego

ZONEEDIT_USER="xxx" \
ZONEEDIT_AUTH_TOKEN="yyy" \
./dist/lego --email you@example.com --dns zoneedit -d '*.example.com' -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory  run
    Note that the wildcard domain is important.
  • pass the linter
  • do go mod tidy

Ping @mikaelheidrich, can you run the command (with your domain, email, credentials, etc.)?

Closes #2577

How to test this PR?
  1. You need Go
  2. Check out the PR: 
    git clone https://github.com/ldez/lego.git
cd lego
git checkout feat/zoneedit
  3. Compile lego:
    • if you have make: make build
    • if you don't make make: go build -o dist/lego ./cmd/lego
  4. Run the following command with your information (email, domain, credentials): 
    ZONEEDIT_USER_ID="xxx" \
ZONEEDIT_PASSWORD="yyy" \
./dist/lego --email you@example.com --dns zoneedit -d '*.example.com' -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
    The wildcard domain is important
  5. Before each run of the command, you should clean your local environment: 
    rm -rf .lego

@ldez ldez mentioned this pull request Jul 10, 2025
Closed
5 tasks
@ldez ldez marked this pull request as draft July 10, 2025 20:56
@ldez ldez added the waiting-for/user-tests Need users to test functionality label Jul 10, 2025
@mikaelheidrich

This comment was marked as outdated.

Sign in to view
@mikaelheidrich

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@mikaelheidrich

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@mikaelheidrich

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@mikaelheidrich

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@mikaelheidrich

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@mikaelheidrich

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@mikaelheidrich

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@mikaelheidrich

This comment was marked as outdated.

Sign in to view
@mikaelheidrich

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@mikaelheidrich

This comment was marked as outdated.

Sign in to view
@mikaelheidrich

This comment was marked as outdated.

Sign in to view
@mikaelheidrich

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@mikaelheidrich

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@mikaelheidrich
Copy link

mikaelheidrich commented Jul 11, 2025 •
edited by ldez
Loading

@ldez You my friend are a wizard!

<SUCCESS CODE="200" TEXT="_acme-challenge.example.ca TXT with rdata yaZy0O9QYEKtqBWeJqq7vJYjFuUoB0c0dzjo7UaJcMs deleted" ZONE="example.ca">

2025/07/11 17:54:31 [INFO] [*.example.ca, example.ca] acme: Validations succeeded; requesting certificates
2025/07/11 17:54:31 [INFO] Wait for certificate [timeout: 30s, interval: 500ms]
2025/07/11 17:54:32 [INFO] [*.example.ca] Server responded with a certificate.

@ldez
Copy link
Member Author

ldez commented Jul 11, 2025

Thank you ❤️

I will remove the debug logs, and the PR will be OK.

@mikaelheidrich
Copy link

mikaelheidrich commented Jul 11, 2025

I used my login username for the zoneedit account along with the token that is fetched from the DYNS and then settings section of the domain management section of the Zoneedit account. It successfully wrote and deleted the TXT to cname and fetched the certificates.

@mikaelheidrich
Copy link

mikaelheidrich commented Jul 11, 2025

Will this work in Traefik? should I make a request over there?

@ldez
Copy link
Member Author

ldez commented Jul 11, 2025

I will also rename the options.

ZONEEDIT_USER_ID -> ZONEEDIT_USER
ZONEEDIT_PASSWORD -> ZONEEDIT_AUTH_TOKEN

Will this work in Traefik? should I make a request over there?

Yes, it will with Traefik when lego will be released and updated inside Traefik

No, you don't need to request Traefik about that.
When I will release lego, I will open a PR to update Traefik.

@ldez ldez removed the waiting-for/user-tests Need users to test functionality label Jul 11, 2025
@mikaelheidrich
Copy link

mikaelheidrich commented Jul 11, 2025

fantastic! Thank you so much and all the best!

@ldez ldez marked this pull request as ready for review July 11, 2025 16:15
@ldez ldez requested a review from dmke July 11, 2025 16:15
dmke
dmke requested changes Jul 12, 2025
View reviewed changes
@ldez ldez requested a review from dmke July 12, 2025 10:40
@ldez ldez enabled auto-merge (squash) July 12, 2025 12:14
@ldez ldez merged commit b8beddc into go-acme:master Jul 12, 2025
7 checks passed
@ldez ldez deleted the feat/zoneedit branch July 12, 2025 12:20
@ldez ldez added this to the v4.25 milestone Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmke dmke dmke approved these changes

Assignees

No one assigned

Labels

area/dnsprovider enhancement new-provider

Milestone

v4.25

Development

Successfully merging this pull request may close these issues.

Support for provider: Zoneedit

3 participants

@ldez @mikaelheidrich @dmke