Adds per-check timeouts #80
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This is a replacement for #77 which had a really bad rebase. |
ceaa520 to
e8041e6
Compare
Use `-check.timeout=<duration string>` to set a timeout period for each check. If the timeout is reached, the test suite will panic. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
e8041e6 to
fd56f06
Compare
niemeyer
requested changes
Dec 8, 2016
Contributor
niemeyer
left a comment
There was a problem hiding this comment.
The idea and the flag looks good. We just need to move the panic to inside the forked call, so that the suite tear down takes place, which means it'll be properly logged and rest of the suite will continue executing.
As a minor, can we please use just testTimeout and TestTimeout instead of checkTimeout and CheckTimeout for the fields? Seems more aligned with existing conventions.
unclejack
added a commit
to unclejack/check
that referenced
this pull request
Dec 19, 2016
|
ping @cpuguy83 PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
-check.timeout=<duration string>to set a timeout period for eachcheck. If the timeout is reached, the test suite will panic.