Refactor: Improve Code Readability with Constants and Early Returns#842
Closed
k-vanio wants to merge 4 commits into
Closed
Refactor: Improve Code Readability with Constants and Early Returns#842k-vanio wants to merge 4 commits into
k-vanio wants to merge 4 commits into
Conversation
|
@k-vanio, you have done good job, two points:
|
Author
|
@lesichkovm Thank you for your feedback! I've addressed the first point by alphabetically sorting the constants. However, regarding the second point about the |
|
Did not see the new function isValidIP. All is good @k-vanio |
VojtechVitek
requested changes
Aug 30, 2023
…alidate the integrity of IP addresses within the X-Forwarded-For (XFF) header.
PauloRobertTlss
approved these changes
Aug 30, 2023
|
LGTM 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: Improve Code Readability with Constants and Early Returns
This commit refactors the
realIPfunction by introducing constants for header names(
trueClientIP,xRealIP,xForwardedFor) to enhance code clarity. Additionally, itutilizes the concept of early returns for simplifying the logic and improving overall
readability.
These changes contribute to better maintainability and understanding of the codebase.