all: rename gocritic to go-critic #1482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
|
CC @ldez |
There was a problem hiding this comment.
Pull Request Overview
This PR renames all occurrences of "gocritic" to "go-critic" to align with the new naming convention for the project's binary and documentation. The changes include updating inline comments, configuration flags, documentation files, test references, and release script filenames.
- Update inline comments and configuration options in linter/linter.go and cmd/gocritic/* files.
- Introduce new files in cmd/go-critic/* and update tests, documentation, and release scripts accordingly.
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| linter/linter.go | Updated comments to reference go-critic instead of gocritic. |
| docs/manifest.md | Updated manifest text for go-critic naming. |
| cmd/gocritic/main.go | Updated executable name from gocritic to go-critic. |
| cmd/gocritic/doc.go | Updated flag set name to go-critic. |
| cmd/gocritic/check.go | Updated flag set name to go-critic. |
| cmd/go-critic/main.go | New main package implementation for go-critic. |
| cmd/go-critic/doc.go | New documentation command implementation for go-critic. |
| cmd/go-critic/check_test.go | Updated integration test to build the renamed executable. |
| cmd/go-critic-analysis/go-critic-analysis.go | New analysis command file for go-critic. |
| checkers/checkers_test.go | Updated test references from cmd/gocritic to cmd/go-critic. |
| checkers/checkers.go | Updated package documentation comment for go-critic. |
| checkers/analyzer/analyzer.go | Updated debug initialization message for go-critic. |
| _scripts/release.go | Updated release script to use go-critic filenames and archive names. |
| README.md | Updated usage instructions and installation commands for go-critic. |
Files not reviewed (1)
- Makefile: Language not supported
Contributor
|
Thank you for the CC. Inside golangci-lint, the name will continue to be |
Member
Author
|
From what I know |
Contributor
|
yes it's safe |
Contributor
|
Have you thought of a different file structure: move the go install -v github.com/go-critic/go-critic@latestinstead of go install -v github.com/go-critic/go-critic/cmd/go-critic@latest |
quasilyte
approved these changes
Apr 1, 2025
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Oct 19, 2025
TekWizely
added a commit
to TekWizely/pre-commit-golang
that referenced
this pull request
Nov 10, 2025
Update invocations and docs to use/reference `go-critic` to match upstream rename. * go-critic/go-critic#1482
TekWizely
added a commit
to TekWizely/pre-commit-golang
that referenced
this pull request
Nov 10, 2025
Update invocations and docs to use/reference `go-critic` to match upstream rename. * go-critic/go-critic#1482
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In release notes we will mention that we've changed
gocriticin path togo-critic. And after 1-2 releases we will drop it.Fixes #1481
CC: @quasilyte @mcandre