proc: fix SP calculation for sigpanic frames on arm64#4319
Merged
Conversation
Contributor
Author
|
For the record, I'm not really sure if this is the best approach because it feels wrong to depend on Also, not sure if using |
derekparker
reviewed
Apr 27, 2026
aarzilli
reviewed
Apr 28, 2026
| } | ||
| mustSupportCore(t) | ||
|
|
||
| tempDir := t.TempDir() |
Member
There was a problem hiding this comment.
Most of this is just withCoreFile right? The only difference is the part where it also reads the stderr? If so we should probably just modify withCoreFile to call CombinedOutput() and return it.
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion. I updated withCoreFile to call CombinedOutput, and then removed all the noise in the new test. Way cleaner for sure.
Without this fix, stack traces from linux/arm64 core dumps showed SP values that differed from the runtime's panic output. Fixes go-delve#3591
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack traces from linux/arm64 core dumps showed SP values that differed from the runtime's panic output.
This patch adds a reproducer based on the original snippet from the issue and a test that tries to verify if the SP is the same.
Fixes #3591