plumbing: transport, refactor transport Endpoint to use url.URL #1706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c89055f to
b9b3969
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Endpoint struct to embed url.URL instead of maintaining separate fields for protocol, user, password, host, port, and path. This simplifies the codebase by leveraging Go's standard library URL handling.
Key changes:
- Replaced custom
Endpointfields with embeddedurl.URLstruct - Updated all references from
ProtocoltoSchemeand adapted field access patterns throughout the codebase - Removed custom
String()method and helper functions (getPort,getPath) in favor of standardurl.URLmethods
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| plumbing/transport/transport.go | Core refactoring: Endpoint now embeds url.URL; removed custom String(), getPort(), getPath() functions |
| submodule.go | Updated field access from Protocol to Scheme |
| remote.go | Updated field access from Protocol to Scheme |
| plumbing/transport/registry_test.go | Updated test assertions from Protocol to Scheme |
| plumbing/transport/ssh/common.go | Adapted to use url.URL methods for Host/Port/User access |
| plumbing/transport/ssh/common_test.go | Updated test expectations for host-port formatting |
| plumbing/transport/git/common.go | Adapted to use url.URL Port() method and updated host handling |
| plumbing/transport/http/common.go | Updated redirect handling and auth extraction to use url.URL fields |
| plumbing/transport/http/common_test.go | Removed obsolete ModifyEndpointIfRedirect test |
| plumbing/transport/transport_test.go | Restructured tests, updated assertions to validate url.URL fields |
Comments suppressed due to low confidence (2)
plumbing/transport/http/common.go:75
- Debug logging statement left in production code. This log.Printf call should be removed or placed behind a debug flag to avoid excessive logging in production environments.
res, err := client.Do(req)
plumbing/transport/http/common.go:562
- Debug logging statement left in production code. This log.Printf call should be removed or placed behind a debug flag to avoid excessive logging in production environments.
return err
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
962e5a4 to
db555c6
Compare
pjbgf
reviewed
Nov 3, 2025
pjbgf
approved these changes
Nov 3, 2025
There's no need to duplicate the logic already present in url.URL and the standard library to parse and handle URLs. This refactor simplifies the codebase by removing redundant fields and methods, and leverages the existing functionality of url.URL. This also remove unused code in transport/http ModifyEndpointIfRedirect and its related tests.
db555c6 to
9c98ad7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to duplicate the logic already present in url.URL and the standard library to parse and handle URLs. This refactor simplifies the codebase by removing redundant fields and methods, and leverages the existing functionality of url.URL.
This also remove unused code in transport/http ModifyEndpointIfRedirect and its related tests.