Skip to content

Fix webhook migration #10641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lafriks merged 1 commit into from
Mar 6, 2020
Merged

Fix webhook migration #10641

lafriks merged 1 commit into from
Mar 6, 2020

Conversation

@jolheiser
Copy link
Member

@jolheiser jolheiser commented Mar 6, 2020 •
edited
Loading

This PR should correct the granular webhook migration. It also tidies up the migration to make it easier to compare to the models structs.

I think the biggest things to note are

  1. Completing the structs, as otherwise I think JSON may have incorrectly assigned some values.
  2. Having a new HookEvent for each loop, as otherwise I think re-using it can cause muddied data.

Proof of concept on why it was failing before: https://play.golang.org/p/_L6VYgQsn1a

@jolheiser
Fix migration
a0f3be2 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser jolheiser added this to the 1.12.0 milestone Mar 6, 2020
guillep2k
guillep2k approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds about right.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 6, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 6, 2020
@lafriks lafriks added the issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP label Mar 6, 2020
@lafriks lafriks merged commit 4a4fc73 into go-gitea:master Mar 6, 2020
@jolheiser jolheiser deleted the fix-webhook-migration branch March 6, 2020 15:58
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+2 more reviewers

@zeripath zeripath zeripath approved these changes

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jolheiser @lafriks @zeripath @guillep2k @GiteaBot