Skip to content

Conversation

@zeripath
Copy link
Contributor

Fix #9950

Signed-off-by: Andrew Thornton art27@cantab.net

Fix go-gitea#9950

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.12.0 milestone Mar 28, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 28, 2020
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!A & !B == A|B

DeMorgans law ftw.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 28, 2020
@codecov-io
Copy link

Codecov Report

Merging #10867 into master will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10867      +/-   ##
==========================================
+ Coverage   43.39%   43.41%   +0.01%     
==========================================
  Files         593      593              
  Lines       83276    83276              
==========================================
+ Hits        36141    36154      +13     
+ Misses      42643    42628      -15     
- Partials     4492     4494       +2     
Impacted Files Coverage Δ
routers/api/v1/org/team.go 37.12% <0.00%> (ø)
routers/api/v1/org/member.go 16.01% <100.00%> (ø)
modules/git/command.go 86.95% <0.00%> (-2.61%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.93%) ⬇️
services/pull/check.go 50.00% <0.00%> (-1.22%) ⬇️
models/error.go 30.50% <0.00%> (+0.54%) ⬆️
routers/repo/view.go 36.82% <0.00%> (+0.67%) ⬆️
modules/log/file.go 77.62% <0.00%> (+2.09%) ⬆️
models/unit.go 44.44% <0.00%> (+2.46%) ⬆️
modules/queue/workerpool.go 60.14% <0.00%> (+3.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 052bff0...50d4f03. Read the comment docs.

@zeripath
Copy link
Contributor Author

@techknowlogick you missed a not:

!A && !B == !(A || B)

😛

@zeripath zeripath merged commit 48890ce into go-gitea:master Mar 28, 2020
@zeripath zeripath deleted the fix-9950 branch March 28, 2020 19:45
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API: Get members of a team as admin

6 participants