Avoiding directory execution on hook (#10954) #10955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test -x is not enough https://stackoverflow.com/a/39489087
zeripath
approved these changes
Apr 4, 2020
Contributor
zeripath
left a comment
There was a problem hiding this comment.
As per @mrsdizzie comment on the underlying issue - however, it's quite a simple test.
Codecov Report
@@ Coverage Diff @@
## master #10955 +/- ##
==========================================
- Coverage 43.62% 43.61% -0.01%
==========================================
Files 597 597
Lines 83923 83923
==========================================
- Hits 36609 36605 -4
- Misses 42802 42807 +5
+ Partials 4512 4511 -1
Continue to review full report at Codecov.
|
mrsdizzie
approved these changes
Apr 4, 2020
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing hooks issue #10954