Skip to content

Fix repository release count when converting for API #10968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zeripath merged 7 commits into from
Apr 6, 2020
Merged

Fix repository release count when converting for API #10968

zeripath merged 7 commits into from
Apr 6, 2020

Conversation

@6543
Copy link
Member

@6543 6543 commented Apr 5, 2020

fix #10946

6543
6543 commented Apr 5, 2020
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 5, 2020
@codecov-io
Copy link

codecov-io commented Apr 5, 2020 •
edited
Loading

Codecov Report

Merging #10968 into master will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10968      +/-   ##
==========================================
- Coverage   43.62%   43.55%   -0.08%     
==========================================
  Files         597      597              
  Lines       83923    83923              
==========================================
- Hits        36614    36554      -60     
- Misses      42797    42862      +65     
+ Partials     4512     4507       -5
Impacted Files Coverage Δ
models/repo.go 51.48% <100.00%> (-0.07%) ⬇️
modules/context/repo.go 57.07% <100.00%> (-0.15%) ⬇️
services/pull/check.go 32.92% <0.00%> (-20.74%) ⬇️
models/repo_mirror.go 2.12% <0.00%> (-10.64%) ⬇️
services/pull/patch.go 62.93% <0.00%> (-4.90%) ⬇️
services/pull/temp_repo.go 29.05% <0.00%> (-2.57%) ⬇️
modules/indexer/issues/indexer.go 56.19% <0.00%> (-1.33%) ⬇️
services/pull/pull.go 34.70% <0.00%> (-1.18%) ⬇️
services/mirror/mirror.go 18.75% <0.00%> (-0.66%) ⬇️
models/pull.go 42.30% <0.00%> (-0.56%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca33a95...eb2f73b. Read the comment docs.

@guillep2k guillep2k added modifies/api This PR adds API routes or modifies them type/bug labels Apr 5, 2020
@guillep2k guillep2k added this to the 1.12.0 milestone Apr 5, 2020
@6543 6543 force-pushed the fix-api-RepoInfo-ReleaseCounter_10946 branch from 3eeb7bb to eb2f73b Compare April 5, 2020 23:25
@6543
Copy link
Member Author

6543 commented Apr 5, 2020

@lunny I removed the NumReleases from the Repo struct

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 6, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 6, 2020
@zeripath
Copy link
Contributor

zeripath commented Apr 6, 2020

make lg-tm work

@zeripath zeripath changed the title [BugFix] [API] repo info release counter Fix release counter on API repository info Apr 6, 2020
@zeripath zeripath changed the title Fix release counter on API repository info Fix repository release count when converting for API Apr 6, 2020
@zeripath zeripath merged commit ad31d6b into go-gitea:master Apr 6, 2020
@6543 6543 deleted the fix-api-RepoInfo-ReleaseCounter_10946 branch April 6, 2020 19:47
6543 added a commit to 6543-forks/gitea that referenced this pull request Apr 6, 2020
@6543
Fix release counter on API repository info (go-gitea#10968)
954368c
@6543 6543 mentioned this pull request Apr 6, 2020
Merged
@techknowlogick techknowlogick added backport/done All backports for this PR have been created backport/v1.11 labels Apr 6, 2020
techknowlogick pushed a commit that referenced this pull request Apr 6, 2020
@6543
[Backport] Fix release counter on API repository info (#10968) (#10996)
0c4be64 
* Fix release counter on API repository info (#10968)

* correct Pull Count to v1.11 Fixtures
@6543 6543 mentioned this pull request Apr 12, 2020
Merged
@6543 6543 mentioned this pull request Apr 20, 2020
Merged
13 tasks
@jolheiser jolheiser mentioned this pull request Apr 26, 2020
Merged
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
Fix release counter on API repository info (go-gitea#10968)
dc2949d 
Use the same mechanism as the webpage for calculating the release count

Fix go-gitea#10946
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny left review comments

+2 more reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

[BUG] [API] RepoInfo incorect Release Counter

8 participants

@6543 @codecov-io @zeripath @lunny @mrsdizzie @techknowlogick @guillep2k @GiteaBot