Skip to content

Fix IsErrPullClosed #10093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zeripath merged 1 commit into from
Feb 1, 2020
Merged

Fix IsErrPullClosed #10093

zeripath merged 1 commit into from
Feb 1, 2020

Conversation

@lunny
Copy link
Member

@lunny lunny commented Feb 1, 2020

As title.

@lunny lunny added the type/bug label Feb 1, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 1, 2020
@codecov-io
Copy link

codecov-io commented Feb 1, 2020

Codecov Report

Merging #10093 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10093      +/-   ##
==========================================
+ Coverage   43.44%   43.45%   +<.01%     
==========================================
  Files         566      566              
  Lines       78987    78987              
==========================================
+ Hits        34318    34322       +4     
+ Misses      40432    40427       -5     
- Partials     4237     4238       +1
Impacted Files Coverage Δ
services/pull/pull.go 33.93% <0%> (ø) ⬆️
services/pull/patch.go 64.77% <0%> (-3.15%) ⬇️
models/repo.go 51.46% <0%> (+0.13%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
models/unit.go 39.5% <0%> (+2.46%) ⬆️
modules/process/manager.go 78.31% <0%> (+3.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d43563...dead55b. Read the comment docs.

bagasme
bagasme reviewed Feb 1, 2020
View reviewed changes
Copy link
Contributor

@bagasme bagasme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply change the method?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 1, 2020
@zeripath zeripath merged commit 107a694 into go-gitea:master Feb 1, 2020
@lunny lunny deleted the lunny/fix_is_err branch February 1, 2020 11:25
@lafriks lafriks added this to the 1.12.0 milestone Feb 1, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@6543 6543 6543 approved these changes

+2 more reviewers

@bagasme bagasme bagasme left review comments

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

7 participants

@lunny @codecov-io @zeripath @6543 @bagasme @lafriks @GiteaBot