Skip to content

Conversation

@mmdoogie
Copy link
Contributor

Similar to #10447 several other admin pages had incorrect AppSubUrl substitutions for their form urls, causing incorrect behavior when running behind a proxy / with a non-root URL. Fixed the two remaining ones I noticed.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 20, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 20, 2020
@lafriks lafriks added this to the 1.13.0 milestone May 20, 2020
@lafriks lafriks added backport/v1.12 skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 20, 2020
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit 689e7e8 into go-gitea:master May 20, 2020
@techknowlogick
Copy link
Member

@mmdoogie please send backport to release/v1.12 branch :)

@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label May 21, 2020
techknowlogick pushed a commit that referenced this pull request May 22, 2020
… (#11531)

* Fix form action template substitution on admin dashboard

* Fix form action template substitution on admin monitoring page

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lauris BH <lauris@nix.lv>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
* Fix form action template substitution on admin dashboard

* Fix form action template substitution on admin monitoring page

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants