Skip to content

Conversation

@6543
Copy link
Member

@6543 6543 commented Jun 17, 2020

Backport #11925

Use ID or Where to instead directly use Get when load object from database

…abase (go-gitea#11925)

* Use ID or Where to instead directly use Get when load object from database

* Apply suggestions from code review

Co-authored-by: 6543 <6543@obermui.de>

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 17, 2020
@zeripath
Copy link
Contributor

make lg-tm work

@zeripath zeripath merged commit ecad970 into go-gitea:release/v1.12 Jun 17, 2020
@6543 6543 deleted the backport_xorm-get_11925_v112 branch June 17, 2020 20:30
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants