Skip to content

Refactor UpdateOAuth2Application #11034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zeripath merged 6 commits into from
Apr 30, 2020
Merged

Refactor UpdateOAuth2Application #11034

zeripath merged 6 commits into from
Apr 30, 2020

Conversation

@6543
Copy link
Member

@6543 6543 commented Apr 10, 2020

as title come up in #11008

@6543 6543 force-pushed the refactor-UpdateOAuth2Application branch from 30405a0 to 919b7d7 Compare April 10, 2020 01:51
@6543 6543 mentioned this pull request Apr 10, 2020
Merged
6543
6543 commented Apr 10, 2020
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 10, 2020
@techknowlogick techknowlogick added this to the 1.12.0 milestone Apr 11, 2020
@techknowlogick techknowlogick added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 11, 2020
@6543
Copy link
Member Author

6543 commented Apr 11, 2020

thx @techknowlogick

@codecov-io
Copy link

codecov-io commented Apr 11, 2020 •
edited
Loading

Codecov Report

Merging #11034 into master will increase coverage by 0.03%.
The diff coverage is 48.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11034      +/-   ##
==========================================
+ Coverage   43.42%   43.46%   +0.03%     
==========================================
  Files         600      600              
  Lines       85022    85026       +4     
==========================================
+ Hits        36922    36954      +32     
+ Misses      43541    43517      -24     
+ Partials     4559     4555       -4
Impacted Files Coverage Δ
routers/user/setting/oauth2.go 0.00% <0.00%> (ø)
models/oauth2_application.go 64.19% <47.82%> (-2.25%) ⬇️
routers/api/v1/user/app.go 68.24% <100.00%> (+0.63%) ⬆️
modules/indexer/stats/db.go 50.00% <0.00%> (-18.75%) ⬇️
modules/log/event.go 64.61% <0.00%> (-1.03%) ⬇️
models/issue.go 51.95% <0.00%> (+0.46%) ⬆️
modules/notification/webhook/webhook.go 40.20% <0.00%> (+0.58%) ⬆️
services/pull/pull.go 34.16% <0.00%> (+0.95%) ⬆️
modules/git/repo.go 51.88% <0.00%> (+1.25%) ⬆️
services/pull/temp_repo.go 34.18% <0.00%> (+2.56%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ef11ff...970535a. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 27, 2020
@6543
Copy link
Member Author

6543 commented Apr 27, 2020 •
edited
Loading

this pull is failing now because of a strange merge behaviour - I'll rebase it

@6543 6543 force-pushed the refactor-UpdateOAuth2Application branch from 806fb33 to de066c4 Compare April 27, 2020 22:17
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 28, 2020
@zeripath
Copy link
Contributor

zeripath commented Apr 30, 2020

make lg-tm work

@zeripath zeripath merged commit ab69b9b into go-gitea:master Apr 30, 2020
@6543 6543 deleted the refactor-UpdateOAuth2Application branch April 30, 2020 18:10
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
Refactor UpdateOAuth2Application (go-gitea#11034)
ac31890 
Following on from go-gitea#11008 refactor UpdateOAuth2Application
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@adelowo adelowo adelowo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

7 participants

@6543 @codecov-io @zeripath @lafriks @adelowo @techknowlogick @GiteaBot