Generalize list header for API#16551
Conversation
Codecov Report
@@ Coverage Diff @@
## main #16551 +/- ##
==========================================
+ Coverage 45.36% 45.40% +0.03%
==========================================
Files 758 758
Lines 85120 85258 +138
==========================================
+ Hits 38612 38708 +96
- Misses 40245 40277 +32
- Partials 6263 6273 +10
Continue to review full report at Codecov.
|
Signed-off-by: Andrew Thornton <art27@cantab.net>
|
@zeripath your commit break this pull :/ |
|
@lunny anything else you like to know? |
|
A helper method may be useful. At the moment there are 37 duplicated code blocks of ctx.Header().Set("X-Total-Count", fmt.Sprintf("%d", totalCount))
ctx.Header().Set("Access-Control-Expose-Headers", "X-Total-Count")If the |
|
had that in mind to ... was lazy and thought ... do it next time 😅 - u catched me will refactor bit more then ... |
|
🚀 |
close #11114