Thanks for this PR, my understanding of golang was that it picks up proxy settings via the HTTP_PROXY environment variable?

The http.DefaultTransport will use proxy from environment, and it's only used when there is no custom transport.

Gitea uses a custom transport without proxy in file modules/migrations/gogs.go and modules/migrations/github.go, so we need to add a proxy.

Maybe we can only use proxy from the environment?

Codecov Report

Merging #16697 (072e8c2) into main (ca13e1d) will increase coverage by 0.04%.
The diff coverage is 48.72%.

@@            Coverage Diff             @@
##             main   #16697      +/-   ##
==========================================
+ Coverage   45.36%   45.40%   +0.04%     
==========================================
  Files         758      758              
  Lines       85120    85306     +186     
==========================================
+ Hits        38612    38732     +120     
- Misses      40245    40294      +49     
- Partials     6263     6280      +17     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf5afe...072e8c2. Read the comment docs.

I think we should reuse HTTP_PROXY env and not introduce new config settings for this

I think we should reuse HTTP_PROXY env and not introduce new config settings for this

Ok, I agree with you and I'll fix this.

I think we should reuse HTTP_PROXY env and not introduce new config settings for this

I don't think so. Assume we want to add proxy for migrating from github but not another gitea instance, how should we do? We should have a global proxy i.e. #15234 and then set the proxy per domain.

I think we should reuse HTTP_PROXY env and not introduce new config settings for this

I don't think so. Assume we want to add proxy for migrating from github but not another gitea instance, how should we do? We should have a global proxy i.e. #15234 and then set the proxy per domain.

Alright. I thought we could set these rules in proxy software.

Since #16704 has been merged, I think we can close this one. @idealism-xxm You can also send another PR to improve the proxy feature.

-> #16704 (comment)