Disable unnecessary OpenID/OAuth2 elements#18491
Merged
Merged
Conversation
This mod fixes disabling unnecessary OpenID elements. Related: go-gitea#13129 Author-Change-Id: IB#1115256
Gusted
reviewed
Jan 31, 2022
| m.Post("/link_account_signup", bindIgnErr(forms.RegisterForm{}), auth.LinkAccountPostRegister) | ||
| m.Group("/link_account", func() { | ||
| m.Get("", auth.LinkAccount) | ||
| }, openIDSignInEnabled) |
Contributor
There was a problem hiding this comment.
openIDSignInEnabled can be added to the Get and Post arguments, no need to go all fancy with Group here.
Contributor
Author
There was a problem hiding this comment.
Just tested that
m.Get("/", Home, openIDSignInEnabled)
does not forbid access to / when openIDSignInEnabled is disabled but
m.Group("/", func() {
m.Get("", Home)
}, openIDSignInEnabled)
does. Seems that simply adding openIDSignInEnabled to Get arguments does not work.
Contributor
Author
There was a problem hiding this comment.
m.Get("/", openIDSignInEnabled, Home)
works ok - will fix it.
Fixes: 8faceac Related: go-gitea#18491 (review) Author-Change-Id: IB#1115256
Gusted
approved these changes
Feb 1, 2022
silverwind
approved these changes
Feb 2, 2022
lunny
requested changes
Feb 2, 2022
Member
lunny
left a comment
There was a problem hiding this comment.
LinkAccount is not only for openID, OAuth2 could also use that. This is totally wrong.
Fixes: 8faceac Related: go-gitea#18491 (review) Author-Change-Id: IB#1115256
Contributor
Author
Fixed in 513303b. |
lunny
approved these changes
Feb 2, 2022
Gusted
approved these changes
Feb 2, 2022
zeripath
approved these changes
Feb 9, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 10, 2022
* giteaofficial/main: Fix issue with docker-rootless shimming script (go-gitea#18690) tests: remove redundant comparison in repo dump/restore (go-gitea#18660) [skip ci] Updated translations via Crowdin Disable unnecessary OpenID/OAuth2 elements (go-gitea#18491) Add apply-patch, basic revert and cherry-pick functionality (go-gitea#17902) C preprocessor colors improvement (go-gitea#18671) Update object repo with the migrated repository (go-gitea#18684)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
This mod fixes disabling unnecessary OpenID elements. Related: go-gitea#13129 Author-Change-Id: IB#1115256
Contributor
|
@pboguslawski this change (maybe) causes regressions like:
Could you propose a proper fix? (I will propose a quick fix to revert this PR for a temp approach) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mod fixes disabling unnecessary OpenID/OAuth2 elements.
Related: #13129
Author-Change-Id: IB#1115256